Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono][jit] Reenable branch optimizations when running with llvm. #97189

Merged
merged 4 commits into from
Jan 29, 2024
Merged

[mono][jit] Reenable branch optimizations when running with llvm. #97189

merged 4 commits into from
Jan 29, 2024

Conversation

vargaz
Copy link
Contributor

@vargaz vargaz commented Jan 19, 2024

No description provided.

@ghost ghost assigned vargaz Jan 19, 2024
@vargaz
Copy link
Contributor Author

vargaz commented Jan 19, 2024

/azp run runtime-extra-platforms

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Jan 19, 2024
Closed
@runfoapp runfoapp bot mentioned this pull request Jan 19, 2024
Open
@vargaz
Copy link
Contributor Author

vargaz commented Jan 21, 2024

/azp run runtime-ioslike

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jan 22, 2024
Open
Closed
@vargaz
Copy link
Contributor Author

vargaz commented Jan 23, 2024

/azp run runtime-wasm

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vargaz vargaz marked this pull request as ready for review January 24, 2024 18:05
@vargaz
Copy link
Contributor Author

vargaz commented Jan 25, 2024

/azp run runtime-ioslike

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vargaz vargaz mentioned this pull request Jan 25, 2024
Merged
@vargaz
Copy link
Contributor Author

vargaz commented Jan 25, 2024

/azp run runtime

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vargaz
Copy link
Contributor Author

vargaz commented Jan 25, 2024

This PR will reduce both executable size and aot compiler memory usage by eliminating code early. Previously, we were only running branch optimizations in opt/llc, so if we had code like:
if (Vector.IsSupported)
the aot compiler couldn't figure out that was not needed, so it ended up generating a lot of extra vector generic instances.

@build-analysis build-analysis bot mentioned this pull request Jan 25, 2024
Open
2 tasks
@vargaz
Copy link
Contributor Author

vargaz commented Jan 25, 2024

/azp runtime-extra-platforms

@azure-pipelines Azure Pipelines
Copy link

Command 'runtime-extra-platforms' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@vargaz
Copy link
Contributor Author

vargaz commented Jan 25, 2024

/azp run runtime-extra-platforms

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

vargaz added 2 commits January 25, 2024 18:34
@vargaz
[mono][llvm] Fix the return type of OP_SSE2_PACKUS.
c927f3f 
This is supposed to return a 16xi8 so there is no need to cast it.
This only worked by accident because the phi handling code casted it
to the right type most of the time.
@vargaz
Disable moving out of line bblocks to the end of code when using llvm.
813974b
@vargaz
Copy link
Contributor Author

vargaz commented Jan 26, 2024

/azp run runtime-extra-platforms

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vargaz
Copy link
Contributor Author

vargaz commented Jan 26, 2024

This saves around 120k on an aot hello world on wasm.

@vargaz
Copy link
Contributor Author

vargaz commented Jan 26, 2024

Failures are probably unrelated, the llvm lanes are timing out.

kg
kg approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@kg kg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the changes to lhs are to fix crashes you hit while doing this. Looks fine to me.

@vargaz vargaz merged commit 027a43b into dotnet:main Jan 29, 2024
152 of 164 checks passed
@vargaz vargaz deleted the llvm-branch2 branch January 29, 2024 18:34
@vargaz vargaz mentioned this pull request Jan 31, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kg kg kg approved these changes

@fanyang-mono fanyang-mono Awaiting requested review from fanyang-mono

@lambdageek lambdageek Awaiting requested review from lambdageek

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

Assignees

@vargaz vargaz

Labels
area-Codegen-JIT-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vargaz @kg